search

ProjectPythia / cookbook-actions

Reusable workflows used by Project Pythia Cookbooks
Apache License 2.0
2 stars 7 forks source link

PR previews are now replacing the main site #130

Closed brian-rose closed 1 month ago

brian-rose commented 1 month ago

I assume this is a bi-product of #125 but I'm not certain.

PR previews are not being deployed to subdirectories labeled by their PR number. Instead, they are deploying directly to the main site URL. This means that every PR that gets opened is effectively "published" immediately, even if the PR is never merged.

Examples in https://github.com/ProjectPythia/cookbook-template/pull/205 and https://github.com/ProjectPythia/HRRR-AWS-cookbook/pull/35.

brian-rose commented 1 month ago

I think that @jbusecke may have already solved this problem with the yet-to-be-merged #126. The current action is not recognizing the input argument BASE_PATH where we are specifying the subdirectory for deployment.

brian-rose commented 1 month ago

I merged #129 which should fix this problem. I will test and find out.

brian-rose commented 1 month ago

This problem was solved after merging #131 but now I'm finding that previews are being deleted whenever the main site is redeployed.

brian-rose commented 1 month ago

I will open a separate issue for this. We may be misunderstanding the intent of the clean-exclude option.