Binder badges on Gallery page don't display on Chrome browser

ProjectPythia / cookbook-gallery

Root site for the ProjectPythiaCookbooks GitHub Pages

https://cookbooks.projectpythia.org

MIT License

0 stars 13 forks source link

Binder badges on Gallery page don't display on Chrome browser #104

Closed brian-rose closed 4 months ago

brian-rose commented 1 year ago

As discussed in #103, the new Binder badges with the correct links drawn dynamically from each Cookbook's _config file do not display properly in the Chrome browser.

brian-rose commented 1 year ago

Here's a partial screenshot of https://cookbooks.projectpythia.org on Safari on MacOS 12.6.1:

and a screenshot of the same page on Chrome:

brian-rose commented 1 year ago

The badges are created dynamically at site build time using this code

Why does it fail on Chrome but not other browsers? (Firefox is also confirmed to work as expected) @ProjectPythia/infrastructure

brian-rose commented 1 year ago

The rendered HTML for the HRRR-AWS cookbook Binder badge on the Gallery page here looks like this:

<a class="reference external" href="http://binder.mypythia.org/v2/gh/ProjectPythia/HRRR-AWS-cookbook.git/main"><img alt="Binder" src="http://binder.mypythia.org/badge_logo.svg"/></a>

while the rendered HTML for the same badge on the README page (which looks fine on Chrome) is this:

<a class="reference external" href="http://binder.mypythia.org/v2/gh/ProjectPythia/HRRR-AWS-cookbook.git/main"><img alt="Binder" src="http://binder.mypythia.org/badge_logo.svg" /></a>

Other than a bit of whitespace, they look identical to me. No idea why the first one does not render properly on Chrome.

ktyle commented 1 year ago

Bringing up the Developer's Console in Chrome, it is 1) replacing http with https, and then 2) throwing an invalid certificate authority error when it tries to load the svg using that protocol. It's happening on my version of Chrome both for the Gallery and README pages.

More impetus for me to get a new Jetstream2 Binderhub instance up which uses https and has a recognized certificate authority.

brian-rose commented 1 year ago

This should go away when our new Pythia binder service is up and running!

brian-rose commented 1 year ago

Update: this problem is mostly resolved since most Cookbooks on the gallery are now linking to the new Pythia binder which uses https.

There are still a couple of Cookbooks on the gallery that are not linking to the new Binder:

Landsat ML Cookbook
xbatcher for Machine Learning Cookbook

There are PRs open in both those repos to get them updated to the latest infrastructure.