ProjectPythia / cookbook-gallery

Root site for the ProjectPythiaCookbooks GitHub Pages
https://cookbooks.projectpythia.org
MIT License
0 stars 13 forks source link

Update cookbook gallery per #117 #120

Closed pythia-pr-machine[bot] closed 1 year ago

pythia-pr-machine[bot] commented 1 year ago

Update cookbook gallery as requested in #117. Closes #117.

github-actions[bot] commented 1 year ago

πŸ‘‹ Thanks for opening this PR! The site will be automatically built with GitHub Actions. To see the status of your deployment, click below. πŸ” Git commit SHA: 95e27d58b4a379d4bd58c9800790c80b3f389d2d βœ… Deployment Preview URL: In Progress

dcamron commented 1 year ago

@ThomasMGeo take a look at the preview link in the comment above and decide if you want to change anything about the gallery card. It will be generated from your JupyterBook _config.yml, so no changes to be made here. Looks to me like you could update the description field and optionally upload a thumbnail and reference its path in the thumbnail field. tags (ft domains and packages as well.)

brian-rose commented 1 year ago

@dcamron since I've been tagged for a review here, let me ask a procedural question. Should we encourage fixes for things like descriptions and gallery tags in the source cookbook repo before approving the gallery change?

dcamron commented 1 year ago

It's in the contributor's guide, but easy to miss. We could add it to the issue template as a quick checklist before opening the issue to begin with.

brian-rose commented 1 year ago

It's in the contributor's guide, but easy to miss. We could add it to the issue template as a quick checklist before opening the issue to begin with.

Ok, so as a reviewer of the gallery change, I should hold off on approving until those changes are made in the other repo?

dcamron commented 1 year ago

Yeah, I think we can keep the discussion here for the moment (though the preview might not be of much use unless we re-run the action.)

ThomasMGeo commented 1 year ago

Description: A small collection of notebooks that explores some (re)gridding options within the Xarray ecosystem.

And my DALLE generated grid image: DALLΒ·E 2023-03-07 08 58 36 - computer grid in the style of tron

ThomasMGeo commented 1 year ago

Thanks for all the work!

dcamron commented 1 year ago

Do you mind going to update these in your book itself? πŸ˜‰

ThomasMGeo commented 1 year ago

Give it another look @dcamron ! Thanks πŸ‘