search

ProjectPythia / cookbook-gallery

Root site for the ProjectPythiaCookbooks GitHub Pages
https://cookbooks.projectpythia.org
MIT License
1 stars 13 forks source link

cookbook gallery filters broken #207

Closed clyne closed 5 months ago

clyne commented 5 months ago

The Cookbook Gallery filters do not seem to be operational. Navigate to the gallery. Click on either of the filters, Domain or Package. Nothing happens.

brian-rose commented 5 months ago

I think this is being worked on in https://github.com/ProjectPythia/cookbook-gallery/pull/199

brian-rose commented 5 months ago

Overall issue is being tracked at https://github.com/ProjectPythia/projectpythia.github.io/issues/419

jukent commented 5 months ago

New PR to fix this is in https://github.com/ProjectPythia/cookbook-gallery/pull/208

Functionality is back, but I was forced to use new Sphinx classes and so the styling isn't pretty.

brian-rose commented 5 months ago

Functionality is back, but I was forced to use new Sphinx classes and so the styling isn't pretty.

With the cookoff next week and many people looking at the gallery and trying to figure out what tags they want to use, I think that functionality >> prettiness.

@jukent assuming #208 gets merged, I think it would be helpful to open an issue describing what you learned, and what's left to do.

jukent commented 5 months ago

Okay. It can be merged today as is if you approve, and I'll open a new issue for improving the styling. This same fix needs to be made in the resource gallery.

I'm OOO today so I can work on that on Monday. I'll document the changes better for anyone who wants to learn/in case something breaks again.

brian-rose commented 5 months ago

Sounds good. I'll merge #208 now and open a placeholder issue about the styling and documentation.