search

ProjectPythia / cookbook-template

Project Pythia Cookbook template
https://projectpythia.org/cookbook-template/
Apache License 2.0
21 stars 16 forks source link

Would a .pre-commit file be helpful? #102

Closed norlandrhagen closed 1 year ago

norlandrhagen commented 1 year ago

Hi there,

Wondering if the use of pre-commit has been considered? It might help to enforce some standardization between cookbooks. If there is any interest, I would be happy to add a config file to the template.

@ktyle @mgrover1

brian-rose commented 1 year ago

Good question @norlandrhagen! We are already using pre-commit on some of our other repos, such as Pythia Foundations.

It makes sense to me to use the same tool for the Cookbooks to ensure some standardization of code style.

norlandrhagen commented 1 year ago

Hi there @brian-rose, sounds great! I added a pre-commit config, which is a duplicate of the one in Pithia Foundations.

Here is the PR: https://github.com/ProjectPythia/cookbook-template/pull/103

brian-rose commented 1 year ago

Closing this with the merger of #103, but just noting here that we might revisit after we see how the pre-commit autoupdates go.