Closed norlandrhagen closed 1 year ago
👋 Thanks for opening this PR! The Cookbook will be automatically built with GitHub Actions. To see the status of your deployment, click below. 🔍 Git commit SHA: b82a4700a7841d02ae4f66db715c0b0cd01a2216 ✅ Deployment Preview URL: https://ProjectPythia.github.io/cookbook-template/_preview/103
Hey there @brian-rose, thanks for the feedback!
I'm fine with any of those. Waiting until prettier 3.0.0
seem fine, definitely don't want to create more tedious cleanup work!
As for exploring option #2, I'm not sure if it works, but can we pin the prettier
version?
Something like is mentioned in this issue: https://github.com/pre-commit/pre-commit-hooks/issues/332
- repo: https://github.com/pre-commit/mirrors-prettier
rev: v2.7.1
hooks:
- id: prettier
additional_dependencies: [prettier@v2.7.1]
As for exploring option #2, I'm not sure if it works, but can we pin the
prettier
version?
I don't know if it will work either, but let's give it a try! We can try it out here in the template repo for a week or so and see what autoupdates get generated. If we're happy these changes, then we can migrate them to all the existing cookbook repos.
Thanks for your contribution @norlandrhagen !
Thanks @brian-rose! Not sure if it'll work, but fingers crossed.
cc @brian-rose