search

ProjectPythia / cookbook-template

Project Pythia Cookbook template
https://projectpythia.org/cookbook-template/
Apache License 2.0
21 stars 16 forks source link

try removing jupyter_server version pin #123

Closed brian-rose closed 1 year ago

brian-rose commented 1 year ago

Do we still need this?

github-actions[bot] commented 1 year ago

👋 Thanks for opening this PR! The Cookbook will be automatically built with GitHub Actions. To see the status of your deployment, click below. 🔍 Git commit SHA: 36a593a655141323c16ee60cf4ade92707f77df7 ✅ Deployment Preview URL: https://ProjectPythia.github.io/cookbook-template/_preview/123

brian-rose commented 1 year ago

The pin was introduced in #101 to resolve #100 due to some upstream changes.

Is this still needed?

brian-rose commented 1 year ago

It looks like the answer is no, we do not still need this pin.

brian-rose commented 1 year ago

I'm going to merge this now (pre-hackathon) because it looks like removing this pin helps resolve some dependency issues on the binder.