Test building on binder with altered environment file

ProjectPythia / cookbook-template

Project Pythia Cookbook template

https://projectpythia.org/cookbook-template/

Apache License 2.0

21 stars 16 forks source link

Test building on binder with altered environment file #128

Closed brian-rose closed 1 year ago

brian-rose commented 1 year ago

I think the logic in the build-book.yaml workflow for dealing with changes in the environment file when building on binder is broken. Testing it here. I expect the build to fail.

github-actions[bot] commented 1 year ago

👋 Thanks for opening this PR! The Cookbook will be automatically built with GitHub Actions. To see the status of your deployment, click below. 🔍 Git commit SHA: e3fa948f2a53fcbc50ca1fa604e8b640d2de911e ✅ Deployment Preview URL: https://ProjectPythia.github.io/cookbook-template/_preview/128

brian-rose commented 1 year ago

Yes, it failed.

The command that got passed to binderbot looked like

python -m binderbot.cli --binder-url https://binder.projectpythia.org/ --repo ProjectPythia/cookbook-template --ref refs/pull/128/merge --nb-timeout 600 $NOTEBOOKS --pass-env-var ARM_USERNAME --pass-env-var ARM_PASSWORD

I'm not sure if the syntax for --repo and --ref are correct.

brian-rose commented 1 year ago

This is now working.