search

ProjectPythia / intake-cookbook

Cookbook showing use of Intake
https://projectpythia.org/intake-cookbook/
Apache License 2.0
1 stars 4 forks source link

make workflows match template #22

Closed jukent closed 1 year ago

jukent commented 1 year ago

https://github.com/ProjectPythiaCookbooks/projectpythiacookbooks.github.io/issues/96#issuecomment-1308765962

github-actions[bot] commented 1 year ago

👋 Thanks for opening this PR! The Cookbook will be automatically built with GitHub Actions. To see the status of your deployment, click below. 🔍 Git commit SHA: 52c618fdde4e4b6953f44d454ec631ef96dbbde9 ✅ Deployment Preview URL: https://ProjectPythiaCookbooks.github.io/intake-cookbook/_preview/22

jukent commented 1 year ago

I'll look for that in the other PRs too

@brian-rose in the other cookbooks, the environment name is just "cookbook-dev" so nothing else needs to be changed in the workflows. Is there a reason to give it a repo specific name?

brian-rose commented 1 year ago

@brian-rose in the other cookbooks, the environment name is just "cookbook-dev" so nothing else needs to be changed in the workflows. Is there a reason to give it a repo specific name?

I think it's a decision for individual cookbook authors to make. The reason is to disambiguate that environment from any number of other cookbook environments that an individual might have installed locally.

jukent commented 1 year ago

Makes sense.