Suggested edits - Githubissues

ProjectPythia / kerchunk-cookbook

Project Pythia cookbook for Kerchunk

https://projectpythia.org/kerchunk-cookbook/

Apache License 2.0

10 stars 11 forks source link

Suggested edits #12

Closed martindurant closed 1 year ago

martindurant commented 1 year ago

Just the README and two foundation notebooks

Some extra thoughts:

all the paragraphs in README are single-line, which is hard to read in diffs. Suggest hard-wrapping
In some cases, the text says you might want to uncomment code, but the code is already uncommented
do we want to time operations, or prove that what we generate is cloud-friendly or at least useful?

github-actions[bot] commented 1 year ago

👋 Thanks for opening this PR! The Cookbook will be automatically built with GitHub Actions. To see the status of your deployment, click below. 🔍 Git commit SHA: da216fe92bd64e64e99d59c272ed6230614a8de6 ✅ Deployment Preview URL: In Progress

norlandrhagen commented 1 year ago

Thanks for the feedback! I'll go through and check on the link breaks & uncomment comments.

Happy to add some timing if you think that'll be useful. Your call.