Previews of PRs are not deploying

ProjectPythia / physical-oceanography-cookbook

Examples of how to use Xarray, Dask, and Holoviews to load, process, and visualize cloud-based ocean data. Datasets include satellite observations (gridded sea-surface height) and ocean model output (POP, MOM6).

http://projectpythia.org/physical-oceanography-cookbook/

MIT License

2 stars 9 forks source link

Previews of PRs are not deploying #9

Closed brian-rose closed 2 years ago

brian-rose commented 2 years ago

E.g. here: https://github.com/ProjectPythiaTutorials/physical-oceanography-cookbook/pull/8

The book gets built, but the preview is not deploying and the link is not updating in the comment.

brian-rose commented 2 years ago

It looks like the steps that actually download the artifact and deploy to GitHub pages are not running because of the link-checker failure #7

This is a bug in the actions... the preview should not be dependent on link checker passing.

brian-rose commented 2 years ago

Yes, the previews work once links are fixed. I'll close this and track the actions bug at https://github.com/ProjectPythiaTutorials/cookbook-template/issues/30