search

ProjectPythia / projectpythia.github.io

https://projectpythia.org
Apache License 2.0
32 stars 18 forks source link

[Security] Workflow linting.yaml is using vulnerable action pre-commit/action #195

Closed Freakston closed 2 years ago

Freakston commented 2 years ago

The workflow linting.yaml is referencing action pre-commit/action using references v2.0.3. However this reference is missing the commit 80db042ff08cdddbbbfb6f89c06a6bfc4dddf0b7 which may contain fix to the some vulnerability. The vulnerability fix that is missing by actions version could be related to: (1) CVE fix (2) upgrade of vulnerable dependency (3) fix to secret leak and others. Please consider to update the reference to the action.

kmpaul commented 2 years ago

Hey, @ProjectPythia/infrastructure: We are using pre-commit-ci, so why do we still have the linting.yml workflow at all? Can we just delete this?

dopplershift commented 2 years ago

Yeah, looks like linting.yml can just be removed since PRs are getting checked by the pre-commit service.

kmpaul commented 2 years ago

Closed with #201 and ProjectPythia/pythia-foundations#203