search

ProjectPythia / projectpythia.github.io

https://projectpythia.org
Apache License 2.0
32 stars 18 forks source link

Refactoring Gallery Generators #256

Closed jukent closed 2 years ago

jukent commented 2 years ago

This pull request makes some of the changes to the cookbook gallery that were noted in #243

What I'd like to do is look at the Pangeo galleries and figure out how they get the badges that represent the health status of the notebook, but this is just to get the badges back in place.

github-actions[bot] commented 2 years ago

This pull request is being automatically built with GitHub Actions and Netlify. To see the status of your deployment, click below.

🔍 Git commit SHA: eac2f1589668f53f03da83edbfaf48bf02d09f3e ✅ Deployment Preview URL: https://628fbc1cc4c404007b1bb287--projectpythia-org.netlify.app

brian-rose commented 2 years ago

Nice, I'm glad to see the Cookbooks link become more prominent!

I noticed on the preview here: https://628e1afaa3453902821eecb7--projectpythia-org.netlify.app/cookbook-gallery.html that there is repeated text. The "about" paragraph is being rendered as subtitle.

jukent commented 2 years ago

Nice, I'm glad to see the Cookbooks link become more prominent!

I noticed on the preview here: https://628e1afaa3453902821eecb7--projectpythia-org.netlify.app/cookbook-gallery.html that there is repeated text. The "about" paragraph is being rendered as subtitle.

Thanks @brian-rose There I was just testing the formatting between subtitles and subtext in that push. I have now removed the subtitle. There are some errors, I will ping you once I have resolved them.

E: @brian-rose I think I've resolved the formatting issues now! I like how it looks.

brian-rose commented 2 years ago

Better!

In the latest preview, I notice that the page layout is different between the Cookbook Gallery https://628e38df3e4b801bd83bb8e0--projectpythia-org.netlify.app/cookbook-gallery.html and the Resource Gallery https://628e38df3e4b801bd83bb8e0--projectpythia-org.netlify.app/resource-gallery.html

Different margins, different title fonts. Is that intentional? IMO the Cookbooks page looks better... I like the wider cards and the smaller title.

jukent commented 2 years ago

@brian-rose I'm agree, I like the Cookbooks better. I'm going to track down the differences in the CSS and maybe confer with @kmpaul on what is happening here. It is non-obvious from the files changed in this PR imo.

kmpaul commented 2 years ago

The reason the two gallery pages look different is because you have to tell the theme to use the standalone page layout for the gallery. See here:

https://github.com/ProjectPythia/projectpythia.github.io/blob/f37196d2deba67bbdaf6df50951a9e96fdcf490a/portal/conf.py#L109

You need to add another item to this configuration for the cookbooks-gallery page.

jukent commented 2 years ago

@kmpaul @brian-rose Done! Now the title "Pythia Cookbooks Gallery" doesn't fit on one line, but it is consistent between gallery pages.

kmpaul commented 2 years ago

To keep the headings short, you probably don't need to start every title with "Pythia...". The top headerbar says "Project Pythia" and is on every page, so it seems redundant to me.

kmpaul commented 2 years ago

...But that can be done in a separate PR. This is good for now. I would merge it.

jukent commented 2 years ago

@kmpaul Great! Yeah I think editing the CSS for different screens and changing the title are the next steps in separate PRs. @jnmorley expressed interest in editing the CSS and learning some Pythia infrastructure.