search

ProjectPythia / projectpythia.github.io

https://projectpythia.org
Apache License 2.0
32 stars 18 forks source link

Remove pinned versions in .pre-commit-config.yaml / update isort #313

Closed ktyle closed 1 year ago

ktyle commented 1 year ago

As noted in #307 , pre-commit was failing with an unhelpful message, The Poetry configuration is invalid. Updating .pre-commit-config.yaml so that the latest (5.12.0) version of isort is used looks to be the key fix here (see #312), but I also eliminated what seems to be unnecessary pinned versions of nbqa-black and nbqa-pyupgrade hooks in nbqa, and also eliminated the now-deprecated seed-isort-config repo.

github-actions[bot] commented 1 year ago

👋 Thanks for opening this PR! The Cookbook will be automatically built with GitHub Actions. To see the status of your deployment, click below. 🔍 Git commit SHA: 1d91d4a7f73a8c01308e68f9da45ddc18904acee ✅ Deployment Preview URL: https://ProjectPythia.github.io/projectpythia.github.io/_preview/313

ktyle commented 1 year ago

Yes @mgrover1 I think we should take a look at ruff! :dog:

brian-rose commented 1 year ago

Maybe then we will stop being hounded by all these pre-commit issues