search

ProjectPythia / projectpythia.github.io

https://projectpythia.org
Apache License 2.0
32 stars 18 forks source link

Add a link-checker to CI tests and nightly builds #315

Closed brian-rose closed 1 year ago

brian-rose commented 1 year ago

This PR extends our CI testing for this repo to include a link checker.

It's expected to fail currently as there are broken links in the repo (#314)

github-actions[bot] commented 1 year ago

👋 Thanks for opening this PR! The Cookbook will be automatically built with GitHub Actions. To see the status of your deployment, click below. 🔍 Git commit SHA: 416554c561a3cc8161f82df53e182c2c7901c673 ✅ Deployment Preview URL: https://ProjectPythia.github.io/projectpythia.github.io/_preview/315

brian-rose commented 1 year ago

Need to the upstream reusable action, it should test for the existence of the _config.yml file before trying to modify it.

brian-rose commented 1 year ago

Ok, fixed that in https://github.com/ProjectPythia/cookbook-actions/pull/35.

Time to try this again.

brian-rose commented 1 year ago

Ok, a different approach to creating the right test environment may be needed here.

brian-rose commented 1 year ago

Ok, this is now gotten to the point where the failures are due to actual link failures. That's good.

brian-rose commented 1 year ago

Links are fixed, link checker is passing.

So merging this closes #314

This is ready for review.