search

ProjectPythia / projectpythia.github.io

https://projectpythia.org
Apache License 2.0
32 stars 18 forks source link

Use the new publish_dir option for deploy-book workflow #331

Closed brian-rose closed 1 year ago

brian-rose commented 1 year ago

Resolves #329

github-actions[bot] commented 1 year ago

👋 Thanks for opening this PR! The Cookbook will be automatically built with GitHub Actions. To see the status of your deployment, click below. 🔍 Git commit SHA: c49e89c699883e43807d00bdbf27e6c771286072 ✅ Deployment Preview URL: https://ProjectPythia.github.io/projectpythia.github.io/_preview/331

brian-rose commented 1 year ago

This needs to be merged before we can actually test if it's working since the preview deployment workflow is running from main branch.

ktyle commented 1 year ago

@brian-rose Great! I notice that the modification that @jukent made in #328 isn't showing up on the preview yet, though.

brian-rose commented 1 year ago

@brian-rose Great! I notice that the modification that @jukent made in #328 isn't showing up on the preview yet, though.

Yeah, due to quirks in how GitHub actions work, we need to merge this first before we can test it.

The preview link is redirecting to the unmodified portal site currently.

brian-rose commented 1 year ago

Great job! Given the importance of this change, I think we should merge ASAP.

Thanks, I'll merge and test right now.