ProjectPythia / pythia-foundations

Jupyterbook source for the Foundations collection
http://foundations.projectpythia.org
Apache License 2.0
59 stars 42 forks source link

Replace styfle/cancel-workflow-action #325

Closed dopplershift closed 1 year ago

dopplershift commented 1 year ago

We should be able to do with with built in concurrency settings in GitHub Actions:

concurrency:
  group: ${{ github.workflow}}-${{ github.head_ref }}
  cancel-in-progress: true

Would eliminate some complexity and an external dependency.

brian-rose commented 1 year ago

I think it would be helpful (from a maintenance perspective) to harmonize the build-and-preview infrastructure for Foundations with what we're doing with Cookbooks.

Once things settle down on the Cookbook front, we should migrate the Cookbook infrastructure to this repo. That would be a good opportunity to eliminate the cancel-workflow-action dependency.

brian-rose commented 1 year ago

Opened #335 to discuss migrating Cookbook infrastructure to this repo. I think we're ready to implement this.

brian-rose commented 1 year ago

Closing since we're using the Cookbook infrastructure now for Foundations.