search

ProjectPythia / pythia-foundations

Jupyterbook source for the Foundations collection
http://foundations.projectpythia.org
Apache License 2.0
59 stars 42 forks source link

Update link to Jupyter logo #329

Closed ktyle closed 1 year ago

ktyle commented 1 year ago

Fixes #328. Note that the new SVG logo is quite a bit smaller than the PNG that we linked to before, but IMHO it's ok.

review-notebook-app[bot] commented 1 year ago

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

github-actions[bot] commented 1 year ago

This pull request is being automatically built with GitHub Actions and Netlify. To see the status of your deployment, click below.

🔍 Git commit SHA: dae05251a9b0e34dad0415a0bec0ebd261da89c6 ✅ Deployment Preview URL: https://6345a19f570045111ab6de46--pythia-foundations.netlify.app

brian-rose commented 1 year ago

Fixes #328. Note that the new SVG logo is quite a bit smaller than the PNG that we linked to before, but IMHO it's ok.

I tried setting width=400 in the image tag so it's consistent with the logos we're using in the GitHub section.

brian-rose commented 1 year ago

I mangled something, sorry. Will fix now.

dopplershift commented 1 year ago

If we wanted the same rectangle, it's available on GitHub at: https://github.com/jupyter/jupyter.github.io/blob/master/assets/logos/rectanglelogo-greytext-orangebody-greymoons.svg

(still would need to specify the width)

brian-rose commented 1 year ago

Can we please get another review here so we can merge this and finally fix the link checker failure?

Tagging a few likely folks... @jukent @dcamron @r-ford