search

ProjectPythia / pythia-foundations

Jupyterbook source for the Foundations collection
http://foundations.projectpythia.org
Apache License 2.0
59 stars 42 forks source link

Remove old version pins from environment #423

Closed brian-rose closed 10 months ago

brian-rose commented 10 months ago

Seeing if we can now remove two likely-obsolete version pins from the environment file.

The scipy pin was introduced recently in https://github.com/ProjectPythia/pythia-foundations/pull/414 waiting until the next Cartopy release. That has happened so we shouldn't need the pin anymore.

The other pin is much older, dating back to the first introduction of the Cartopy notebook https://github.com/ProjectPythia/pythia-foundations/pull/24. I'm not sure the original reason this was needed, but I suspect it's obsolete now.

Testing to see if everything works!

github-actions[bot] commented 10 months ago

👋 Thanks for opening this PR! The Cookbook will be automatically built with GitHub Actions. To see the status of your deployment, click below. 🔍 Git commit SHA: a36fe20071337b579a31f38273a241143fa18c02 ✅ Deployment Preview URL: https://ProjectPythia.github.io/pythia-foundations/_preview/423

brian-rose commented 10 months ago

Looks good to me. Opening this up for review and merge.