search

ProjectPythia / pythia-foundations

Jupyterbook source for the Foundations collection
http://foundations.projectpythia.org
Apache License 2.0
59 stars 42 forks source link

introduction update #460

Open serynabatov opened 2 months ago

serynabatov commented 2 months ago

Hi! I'm a collegue of https://github.com/himahuja. Unfortunatelly I won't be able to participate at the call But he has told me everything.

I will going to provide my reasoning of why I have changed these lines of description.

Plus further I'll create a few different PRs (for the easier review purposes)

review-notebook-app[bot] commented 2 months ago

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

github-actions[bot] commented 2 months ago

👋 Thanks for opening this PR! The Cookbook will be automatically built with GitHub Actions. To see the status of your deployment, click below. 🔍 Git commit SHA: ec471deaf225049faa0264cbddd3fcf5a06683ee ✅ Deployment Preview URL: https://ProjectPythia.github.io/pythia-foundations/_preview/460

serynabatov commented 2 months ago

I have left the comments Please comment me back if you think that something is not applicable Or I should revert it In the meanwhile I'm going to add the new PRs

Have a nice day!

jukent commented 2 months ago

Thanks for this @serynabatov! I just added a couple edits.

serynabatov commented 2 months ago

Hi @jukent !

I haven't found any comments unfortunately Have you submitted the review?

jukent commented 2 months ago

Hi @jukent !

I haven't found any comments unfortunately Have you submitted the review?

Oops! Good catch.

serynabatov commented 2 months ago

@jukent Quick question Does Pythia have some de facto standard to commit the suggestions? I've read them all, they make sense to me

What I mean - should I apply them locally and then update the PR or I can just say to Github "Ok, commit" and you will receive 5 different commits in this branch right now

(The second one won't be a problem though if Pythia squashes the commits)

jukent commented 2 months ago

@jukent Quick question Does Pythia have some de facto standard to commit the suggestions? I've read them all, they make sense to me

What I mean - should I apply them locally and then update the PR or I can just say to Github "Ok, commit" and you will receive 5 different commits in this branch right now

(The second one won't be a problem though if Pythia squashes the commits)

I usually do the 2nd option but it's up to you!

serynabatov commented 2 months ago

Ok, I've applied the comments I'll check the pipelines (where I've been wrong, and then I'll ping you) In the meanwhile I am creating a second PR with the numpy exercises