search

ProjectPythia / vapor-python-cookbook

Getting started with vapor python
https://projectpythia.org/vapor-python-cookbook/
Apache License 2.0
6 stars 4 forks source link

Make consistent with latest template #15

Closed brian-rose closed 4 months ago

brian-rose commented 4 months ago

This PR addresses several inconsistencies in this cookbook's configuration relative to the latest version of the Cookbook template.

It's possible that this will allow this Cookbook to show up in the gallery, i.e. fix https://github.com/ProjectPythia/cookbook-gallery/issues/201. We will probably have to merge this PR first and then try rebuilding the gallery.

github-actions[bot] commented 4 months ago

👋 Thanks for opening this PR! The Cookbook will be automatically built with GitHub Actions. To see the status of your deployment, click below. 🔍 Git commit SHA: 3bb66e2aeb789224ab61c792115a6436ee458e05 ✅ Deployment Preview URL: https://ProjectPythia.github.io/vapor-python-cookbook/_preview/15

NihanthCW commented 4 months ago

Hello @brian-rose , Just checking- the changes seem to be reverting it to the basic configuration. I approved it but is there anything we need to do on our end? Is the duplication caused by the title in _config.yml ?

brian-rose commented 4 months ago

Hi @NihanthCW, I don't really understand what's causing the bug in the gallery https://github.com/ProjectPythia/cookbook-gallery/issues/201. Maybe this will fix it, but even if it doesn't, this PR just removes some unnecessary stuff from the config file so it should be a useful clean-up. And it won't break anything.

Let's merge this and see if it fixes the gallery problem. I don't think there's any other action you need to take.

brian-rose commented 4 months ago

Hi @NihanthCW, glad to say that the VAPOR Cookbook now appears in the Gallery!

There was a bug in the code that generates gallery cards for cookbooks with longer descriptions. It was fixed in https://github.com/ProjectPythia/cookbook-gallery/pull/204. All good now!