search

ProjectQ-Framework / FermiLib

FermiLib: Open source software for analyzing fermionic quantum simulation algorithms
https://projectq.ch/
Apache License 2.0
86 stars 38 forks source link

Allow arbitrary keys for normal_ordering #63

Closed idk3 closed 7 years ago

babbush commented 7 years ago

As we discussed in person, I think there is a better solution to the problem this solves so I will close the pull request for now.

babbush commented 7 years ago

As Damian mentioned, I should really explain why we made certain decisions when discussed offline so people know what is going on. Basically, there is currently a mismatch in convention between code that Ian is writing to apply a Fourier transformation to a state and the code that Wei wrote to apply the Fourier to mode operators. Ian figured out he could fix this by enforcing a different normal ordering after using Wei's code. But I think it is confusing and unnecessary to have two different normal ordering procedures. I told Ian it was better to change Wei's code so that it conforms to Ian's code. That way all of our code would be compatible with the same normal ordering convention.