search

ProjectQ-Framework / ProjectQ

ProjectQ: An open source software framework for quantum computing
https://projectq.ch
Apache License 2.0
888 stars 274 forks source link

Amplitude Amplification algorithm as a Gate in ops #327

Closed fernandodelaiglesia closed 5 years ago

fernandodelaiglesia commented 5 years ago

Dear friends,

Following the same path I did for Phase Estimation, I would like to add the Amplitude Amplification algorithm as a gate in ops.

Any comment will be welcome.

Thanks

fernandodelaiglesia commented 5 years ago

Dear all,

were you able to go over this pull request?

Any feedback will be welcome

Thanks Best

Takishima commented 5 years ago

Sorry about that. I was busy with a ton of other things recently. I’ll look up this PR until next week.

fernandodelaiglesia commented 5 years ago

Thank you. I fully understand you ;-)

fernandodelaiglesia commented 5 years ago

Also, please go through the code and make sure that no line extends past the 80 character mark whenever that is possible.

I tried to do my best, but some lines cannot be splitted because python do not interpret them as a single command

fernandodelaiglesia commented 5 years ago

@Takishima,

I did the changes you suggested and commit again the PR, but the tests fail because of the issue with the phaseestimation_test I corrected in #328 . I was able to rerun the Travis tests for #328 with success. Can you please go over PR #328 and merge it if you think so in order to be able tu pass the tests for this PR?

Thanks a lot in advance Best

Takishima commented 5 years ago

Looks good to me now. Many thanks for your work in submitting this to ProjectQ.