search

ProjectQ-Framework / ProjectQ

ProjectQ: An open source software framework for quantum computing
https://projectq.ch
Apache License 2.0
888 stars 274 forks source link

Bernstein-Vazirani tutorial for ProjectQ v0.4.2 #338

Closed cmleecm closed 5 years ago

cmleecm commented 5 years ago

I have created a Bernstein-Vazirani tutorial jupyter notebook and would like to contribute to the examples.

Takishima commented 5 years ago

Feel free to do so by either pushing it to your master branch (in which case the changes will appear in this PR) or push those changes into a new branch and open a new PR.

cmleecm commented 5 years ago

Feel free to do so by either pushing it to your master branch (in which case the changes will appear in this PR) or push those changes into a new branch and open a new PR.

It seems I have already push it to my master branch. Is there anything else I need to do?

Takishima commented 5 years ago

Are you sure you are pushing to the master branch and not develop? Because if you were, GitHub should show the commits in this PR, which it is not.

cmleecm commented 5 years ago

Help needed here. I have changed the base branch to the master branch. Is this pushing to the master branch?

Takishima commented 5 years ago

You are now indeed pushing to the master branch, but because you were probably working off of the develop branch previously, a bunch of unwanted commits have made their way into this PR.

Could you please apply your changes on top of the develop branch and then do a new PR between the current develop and your fork?

cmleecm commented 5 years ago

Got it. I have created a new pull request #342 to merge the newly added berstein-vazirani_tutorial.ipynb from cmleecm:develop to ProjectQ-Framework:develop