search

ProjectQ-Framework / ProjectQ

ProjectQ: An open source software framework for quantum computing
https://projectq.ch
Apache License 2.0
874 stars 271 forks source link

Add a backend for IonQ. #391

Closed amilstead closed 3 years ago

amilstead commented 3 years ago

Hello ProjectQ!

Here is a first pass at a direct IonQ backend. Welcoming all feedback!

amilstead commented 3 years ago

@Takishima Thanks for the review! I believe this is ready for another pass.

amilstead commented 3 years ago

I am just waiting on the confirmation that you have signed the ProjectQ license agreement (you should have gotten an email or will get it soon about the details of it). Once that is done I will merge the branch and prepare the release of a new version of ProjectQ as soon as possible.

Awesome! Thanks a lot! Looking forward to the release. 🎉

Takishima commented 3 years ago

I have received confirmation that the CLA was signed a few days ago. I will merge this in the coming days and start the release process for the next version of ProjectQ shortly thereafter. However, I would like to have PR #395 land first (and it should be reviewed soon) since that one has a few important features pertaining to the release process.

amilstead commented 3 years ago

I will merge this in the coming days and start the release process for the next version of ProjectQ shortly thereafter.

🎉 Awesome! Thank you!

However, I would like to have PR #395 land first

Sounds good! I'll keep an eye on that PR. Please let me know if there is anything else I can do until the merge.

amilstead commented 3 years ago

Hey @Takishima -- any updates on when we might be able to expect #395 to merge?

Thanks!

Takishima commented 3 years ago

Hey @Takishima -- any updates on when we might be able to expect #395 to merge?

Thanks!

I wish I could give you a satisfactory answer, but I am currently waiting on @andreashehn to finish his review (although I know he has started looking at it).

Unfortunately, he has been pretty busy with his work over the last few weeks. My hope is that by the end of this week or beginning of the next he should be able to find some time to finish his review and then I will be able to merge #395 and this PR.

amilstead commented 3 years ago

Thanks! I'll check back in early next week!

amilstead commented 3 years ago

Hey @Takishima,

Checking in as promised. Any luck with #395? I see no movement so far so assuming not, but checking nonetheless.

Takishima commented 3 years ago

Hey @Takishima,

Checking in as promised. Any luck with #395? I see no movement so far so assuming not, but checking nonetheless.

No unfortunately not. I am gently reminding him every week without success so far, but I am sure that once things settle down a little for him at work he will submit his review.

amilstead commented 3 years ago

@Takishima thanks again for the nudge in the right direction with this qubit mapper. I am WAY happier with how this looks/feels now.

Please let me know what still needs work!

Takishima commented 3 years ago

So, #395 just landed and it is probably going to require a few modifications to your code, though I do not expect anything too major. You might want to rebase you branch onto the new develop and force-push it to update this PR.

amilstead commented 3 years ago

So, #395 just landed and it is probably going to require a few modifications to your code, though I do not expect anything too major. You might want to rebase you branch onto the new develop and force-push it to update this PR.

Thanks! I'll work on this starting today.

amilstead commented 3 years ago

@Takishima This should be updated now. That said, I did run into some issues with pytest locally, on revkit code, but this happened on develop for me as well.

One other thing I decided to push here too-- making sure that ProjectQ qubit IDs are actually used when setting Qubit object result values from our API response.

Takishima commented 3 years ago

I am happy to merge this if you are happy with it too ;-)

amilstead commented 3 years ago

I am happy to merge this if you are happy with it too ;-)

Let's rock and roll!! Thanks for your patience and attention on this!

Takishima commented 3 years ago

I am happy to merge this if you are happy with it too ;-)

Let's rock and roll!! Thanks for your patience and attention on this!

Thank you for taking the time to adjust and tweak your code along the way. I will merge this later tonight and then probably release a new version of ProjectQ by the end of the week.

amilstead commented 3 years ago

I am happy to merge this if you are happy with it too ;-)

Let's rock and roll!! Thanks for your patience and attention on this!

Thank you for taking the time to adjust and tweak your code along the way. I will merge this later tonight and then probably release a new version of ProjectQ by the end of the week.

Sounds great. Please let me know what I can do to help, if anything.