ProjectQ-Framework / ProjectQ

ProjectQ: An open source software framework for quantum computing
https://projectq.ch
Apache License 2.0
871 stars 270 forks source link

Add support for dynamic backends for IonQ #428

Closed Cynocracy closed 2 years ago

Cynocracy commented 2 years ago

Using the backends endpoint, add available backends to the list.

coveralls commented 2 years ago

Pull Request Test Coverage Report for Build 2147249411


Changes Missing Coverage Covered Lines Changed/Added Lines %
projectq/setups/ionq.py 4 5 80.0%
<!-- Total: 13 14 92.86% -->
Totals Coverage Status
Change from base Build 2147243803: -0.01%
Covered Lines: 7000
Relevant Lines: 7001

💛 - Coveralls
Takishima commented 2 years ago

Don't worry about the CentOS CI failures. Those distros have reached EOL and will be fixed or removed from the CI in a separate PR.

Takishima commented 2 years ago

Also, could you please send an email to info@projectq.ch to request a link to sign the ProjectQ CLA?

Cynocracy commented 2 years ago

Thank you for the speedy review! Will take a look sometime today :)

Cynocracy commented 2 years ago

Also, could you please send an email to info@projectq.ch to request a link to sign the ProjectQ CLA?

Done, added changelog, and formatted things. Let me know what you think! Sorry if I missed anything

Takishima commented 2 years ago

I double checked and it appears that we will have to require you to sign the ProjectQ CLA in order to merge these changes.

Could you please send an email to info@projectq.ch requesting the link to sign the CLA?

In the meantime I will try to work on a PR to address the CI issues.

Cynocracy commented 2 years ago

Sure! Sent an email but haven't gotten a response yet, should I send another?

Takishima commented 2 years ago

Sure! Sent an email but haven't gotten a response yet, should I send another?

I cannot find trace of this email anywhere in the ProjectQ mailbox... Could you try again and CC me in the email (damien.nguyen@alumni.epfl.ch)

If that one does not get through I will manually forward this to the right person.

Takishima commented 2 years ago

Sure! Sent an email but haven't gotten a response yet, should I send another?

Thanks for re-sending the email, you should receive an email to sign the CLA shortly. Sorry about that delay.

Cynocracy commented 2 years ago

Thanks! Should I have the CLA now? Wasn't sure I saw it

Takishima commented 2 years ago

Thanks! Should I have the CLA now? Wasn't sure I saw it

Yes, you should have received a mail about it by now.

Cynocracy commented 2 years ago

Got it now! Signed and returned :)

Takishima commented 2 years ago

Got it now! Signed and returned :)

I can confirm that from my end as well. I have just merged #429 so I just let the CI run once more and if everything looks good, I'll merge this.

Cynocracy commented 2 years ago

Thank you!