ProjectRadiant / official_devices

4 stars 3 forks source link

Application to become an official maintainer for Redmi 4A and Redmi 5A using a unified tree #35

Closed ItoRenz closed 3 years ago

ItoRenz commented 3 years ago

Device you want to apply for

Redmi 4A (rolex)

Device tree sources

https://github.com/ItoRenz/device_xiaomi_rolex
https://github.com/ItoRenz/kernel_xiaomi_rolex
https://github.com/ItoRenz/vendor_xiaomi_rolex

Link to the platform where you have released your unofficial build

https://t.me/Redmi5AID_Channel/4487
https://t.me/Redmi5AID_Channel/4503
https://t.me/RolexIndonesiaChannel/6546
https://t.me/RolexIndonesiaChannel/6555

Other ROM's you maintain officially or unofficially

Project Sakura Unofficial
LineageOS Unofficial
Resurrection Remix Unofficial

Bugs on unofficial build

None

How long have you been building for?

2 Months

Did you properly read Device stability requirements and Maintainer requirements before applying? What part of those requirements do you violate?

I read everything properly and I violate none of the requirements.

SELinux status?

Enforcing.

Are you using a prebuilt kernel? If yes, why?

No.

Contact

Telegram username

@ItoRenz
Maitreya29 commented 3 years ago

Your bringup was better than others, no useless defunct flags however some of your commits need authorship.

Also, we only let maintainers do 3 ROMs including ours and you fall out of their category since you're already doing 3. This included would be 4.

ItoRenz commented 3 years ago

That other rom is unofficial and for resurrection remix I build it only for test device tree And for commits I will give authorship

Maitreya29 commented 3 years ago

That other rom is unofficial and for resurrection remix I build it only for test device tree And for commits I will give authorship

official or unofficial it doesnt matter.

ItoRenz commented 3 years ago

That other rom is unofficial and for resurrection remix I build it only for test device tree And for commits I will give authorship

official or unofficial it doesnt matter.

Yes,that right sir. I only focused to build nezuko and sakura, I will add the authorship for my commits first

ItoRenz commented 3 years ago

I have corrected my commit, you can check it sir https://github.com/ItoRenz/device_xiaomi_rolex

Maitreya29 commented 3 years ago

I have corrected my commit, you can check it sir https://github.com/ItoRenz/device_xiaomi_rolex

they look the same

no authorship for those props

ItoRenz commented 3 years ago

I have corrected my commit, you can check it sir https://github.com/ItoRenz/device_xiaomi_rolex

they look the same

no authorship for those props

Ah authorship for tweak management ram?

Maitreya29 commented 3 years ago

The fact that you know about it and stuff is messed up, you should always author. There are also not enough contributions however as a beginner you're much better than some of the people applying here even with almost a year of experience. However I'd still say no for now. Please reapply later, this isn't exactly a rejection just a request to re-apply after sometime.