search

ProjectSWGCore / Holocore

This is the Star Wars Galaxies server emulator for the Java Virtual Machine
https://www.projectswg.com
GNU Affero General Public License v3.0
30 stars 20 forks source link

Switching factions resets your faction rank #1267

Closed madsboddum closed 1 year ago

madsboddum commented 1 year ago

If you're an imperial colonel and you switch to the rebels, you shouldn't be a colonel.

We should add a check here: com.projectswg.holocore.services.gameplay.faction.FactionFlagService#handleTypeChange ... where we check if target is a CreatureObject and set faction rank to 0 if this is the case.

Undercova commented 1 year ago

Working as intended