search

ProjectSWGCore / Holocore

This is the Star Wars Galaxies server emulator for the Java Virtual Machine
https://www.projectswg.com
GNU Affero General Public License v3.0
30 stars 20 forks source link

Combat engine refactor #1347

Open madsboddum opened 1 year ago

madsboddum commented 1 year ago

The combat engine code could really use a refactor. Especially CombatCommandAttack - the class is huge and has a ton of complexity inside it. It has become difficult to expand. The code is in this package: com.projectswg.holocore.services.gameplay.combat.command

The code is also hard to test, because there's a lot of chance involved. Perhaps when instrumenting the code, we can supply a hardcoded die roll.

Undercova commented 5 months ago

is this still an "issue" / task ?

madsboddum commented 5 months ago

is this still an "issue" / task ?

Yeah but probably a bit low priority for now. We have a lot of combat stuff implemented already, compared to many other game systems currently.