ProjectSWGCore / Holocore

This is the Star Wars Galaxies server emulator for the Java Virtual Machine
https://www.projectswg.com
GNU Affero General Public License v3.0
30 stars 19 forks source link

Enhance faction service so some factions can be excluded from gaining/losing points #1469

Open Undercova opened 11 months ago

Undercova commented 11 months ago

Problem:

The amount of factions that are listed in the official string files is currently limited. To get more options about NPC vs NPC war we can currently add more factions that are not known to the system since they are not in the stf files. When i add a new scenery where a new faction should fight another new/old faction i can easily add those to the faction sdb. they will fight fine vs. each other. Problem pops up when you attack them and they spam your screen with messages of unknown faction strings.

Idea:

2 layers

Solution:

Keep faction service as it is but exclude point granting/deduction if set in table. Create a boolean column in the faction sdb where you can set if the faction will be displayed/counted when you kill a member of it

Undercova commented 11 months ago

I have added a new colum called "SysMsg"

https://github.com/ProjectSWGCore/Holocore/pull/1470/commits/44e46fd54d45d485b697b56a8c3e4a6439979216

if TRUE = show and calculate like right now if FALSE = ignore sending system message and the faction point calculation