search

ProjectSWGCore / Holocore

This is the Star Wars Galaxies server emulator for the Java Virtual Machine
https://www.projectswg.com
GNU Affero General Public License v3.0
30 stars 20 forks source link

Unable to request friends list #1555

Open madsboddum opened 3 months ago

madsboddum commented 3 months ago

Started happening recently. Relevant server log:

11-06-24 14:30:26.972 T: [CommandQueueService] user/Ejurhu Graohori executed command getfriendlist
11-06-24 14:30:26.981 E: Fatal Exception while processing intent: ExecuteCommandIntent(source=CreatureObject[10448905 'Ejurhu Graohori' creature/player/shared_twilek_male.iff], target=null, arguments=, command=getfriendlist:-282986034)
11-06-24 14:30:26.982 E: Exception in thread "intent-processor-10" java.lang.RuntimeException: java.lang.reflect.InvocationTargetException
11-06-24 14:30:26.982 E: Caused by: java.lang.RuntimeException: java.lang.reflect.InvocationTargetException
11-06-24 14:30:26.982 E:     me.joshlarson.jlcommon.control.Service.invoke(Service.java:135)
11-06-24 14:30:26.982 E:     me.joshlarson.jlcommon.control.Service.lambda$registerIntentHandlers$1(Service.java:119)
11-06-24 14:30:26.982 E:     me.joshlarson.jlcommon.control.IntentManager$IntentRunner.broadcast(IntentManager.java:214)
11-06-24 14:30:26.982 E:     me.joshlarson.jlcommon.control.IntentManager$IntentExecutor.run(IntentManager.java:269)
11-06-24 14:30:26.982 E:     me.joshlarson.jlcommon.utilities.ThreadUtilities.safeRun(ThreadUtilities.java:47)
11-06-24 14:30:26.982 E:     me.joshlarson.jlcommon.concurrency.ThreadPool$ThreadExecutor.threadExecutor(ThreadPool.java:174)
11-06-24 14:30:26.982 E:     java.base/java.lang.Thread.run(Thread.java:1583)
11-06-24 14:30:26.982 E:   Exception in thread "intent-processor-10" java.lang.reflect.InvocationTargetException: null
11-06-24 14:30:26.982 E:   Caused by: java.lang.reflect.InvocationTargetException: null
11-06-24 14:30:26.982 E:       java.base/jdk.internal.reflect.DirectMethodHandleAccessor.invoke(DirectMethodHandleAccessor.java:115)
11-06-24 14:30:26.982 E:       java.base/java.lang.reflect.Method.invoke(Method.java:580)
11-06-24 14:30:26.982 E:       me.joshlarson.jlcommon.control.Service.invoke(Service.java:133)
11-06-24 14:30:26.982 E:       me.joshlarson.jlcommon.control.Service.lambda$registerIntentHandlers$1(Service.java:119)
11-06-24 14:30:26.982 E:       me.joshlarson.jlcommon.control.IntentManager$IntentRunner.broadcast(IntentManager.java:214)
11-06-24 14:30:26.982 E:       me.joshlarson.jlcommon.control.IntentManager$IntentExecutor.run(IntentManager.java:269)
11-06-24 14:30:26.982 E:       me.joshlarson.jlcommon.utilities.ThreadUtilities.safeRun(ThreadUtilities.java:47)
11-06-24 14:30:26.982 E:       me.joshlarson.jlcommon.concurrency.ThreadPool$ThreadExecutor.threadExecutor(ThreadPool.java:174)
11-06-24 14:30:26.982 E:       java.base/java.lang.Thread.run(Thread.java:1583)
11-06-24 14:30:26.982 E:     Exception in thread "intent-processor-10" java.lang.NullPointerException: Parameter specified as non-null is null: method com.projectswg.holocore.intents.support.global.chat.ChatAvatarRequestIntent.<init>, parameter target
11-06-24 14:30:26.982 E:     Caused by: java.lang.NullPointerException: Parameter specified as non-null is null: method com.projectswg.holocore.intents.support.global.chat.ChatAvatarRequestIntent.<init>, parameter target
11-06-24 14:30:26.982 E:         com.projectswg.holocore.intents.support.global.chat.ChatAvatarRequestIntent.<init>(ChatAvatarRequestIntent.kt)
11-06-24 14:30:26.982 E:         com.projectswg.holocore.resources.support.global.commands.callbacks.chat.friend.CmdGetFriendList.execute(CmdGetFriendList.java:13)
11-06-24 14:30:26.983 E:         com.projectswg.holocore.services.support.global.commands.CommandExecutionService.handleExecuteCommandIntent(CommandExecutionService.java:78)
11-06-24 14:30:26.983 E:         java.base/jdk.internal.reflect.DirectMethodHandleAccessor.invoke(DirectMethodHandleAccessor.java:103)
11-06-24 14:30:26.983 E:         java.base/java.lang.reflect.Method.invoke(Method.java:580)
11-06-24 14:30:26.983 E:         me.joshlarson.jlcommon.control.Service.invoke(Service.java:133)
11-06-24 14:30:26.983 E:         me.joshlarson.jlcommon.control.Service.lambda$registerIntentHandlers$1(Service.java:119)
11-06-24 14:30:26.983 E:         me.joshlarson.jlcommon.control.IntentManager$IntentRunner.broadcast(IntentManager.java:214)
11-06-24 14:30:26.983 E:         me.joshlarson.jlcommon.control.IntentManager$IntentExecutor.run(IntentManager.java:269)
11-06-24 14:30:26.983 E:         me.joshlarson.jlcommon.utilities.ThreadUtilities.safeRun(ThreadUtilities.java:47)
11-06-24 14:30:26.983 E:         me.joshlarson.jlcommon.concurrency.ThreadPool$ThreadExecutor.threadExecutor(ThreadPool.java:174)
11-06-24 14:30:26.983 E:         java.base/java.lang.Thread.run(Thread.java:1583)
madsboddum commented 3 months ago

Given that this is a regression, we should probably cover the feature with some (basic) test cases.