search

ProjectSWGCore / NGECore2

The ProjectSWG Open Source Core
projectswg.com
GNU Lesser General Public License v3.0
23 stars 70 forks source link

Waypoints #1157

Closed wallaceg09 closed 10 years ago

wallaceg09 commented 10 years ago

This is my first attempt at a contribution to an external project, so if I did anything wrong please forgive me.

I managed to fix waypoints defaulting to (0,0,0). it was a simple fix, however there seems to be a problem in the Engine Code concerning engine.resources.objects.SWGObject with respect to IntangibleObject's "super" call. It seems that when "super" is called to SWGObject, it passes a legitimate "position" object, however the SWGObject that is created seems to always have a "null" position parameter. So it seems to me that the constructor call to SWGObject doesn't actually initialize its position parameter. This bug doesn't appear to be game breaking, however when ObjectService.destroy() is called in the Python script "serverdestroyobject.py" the server receives a NullPointerException. This leads me to believe that objects aren't being deleted server side, only client side, leading to possible memory leaks. Well, at least for waypoints that is.

lewismorgan commented 10 years ago

Thanks for the info @wallaceg09 I'll take a look at that in the engine and have @Obique do so as well since he's been working on that stuff. Commit is good, no other verification required.