search

ProjectSWGCore / NGECore2

The ProjectSWG Open Source Core
projectswg.com
GNU Lesser General Public License v3.0
23 stars 70 forks source link

Fixed Appearance Item Client Crash. See notes #1202

Closed ghost closed 10 years ago

ghost commented 10 years ago

Currently multiple items can be assigned to the appearance item tab when radial then equip appearance.

Treeku commented 10 years ago

Yeah, this should fix it. Should be good to merge unless you are changing something else as well.

ghost commented 10 years ago

Thanks Treeku, That is all I am merging. Just want a dev to approve/merge it. It seems some sort of system will still need to be created to handle putting multiple items into a single appearance slot.

Treeku commented 10 years ago

In theory it's possible it doesn't handle it well when you equip something of the same slot type for appearance. It probably wouldn't be a bad idea to make an appearance equip function in equipmentService to handle that.

What exactly happens if you try to appearance equip something of the same slot type as something that's already appearance equipped?

ghost commented 10 years ago

it equips the appearance also. allowing multiple lets say appearance pants to be worn. It causes clipping in the graphics. I think just a check of some sort to see if something is already there and remove it like in the standard equip setup.