Updates to "Tasty Dried Critters" Quest and QuestService Update

[cdmpse]

Any help on why BuffService is deleted and added for two lines of change is appreciated.

[CharonInferar]

You must have deleted the Buffservice in your repo, it clearly still exists in upstream: https://github.com/ProjectSWGCore/NGECore2/blob/master/src/services/BuffService.java

[cdmpse]

Is there any way to fix that? I tried deleting it locally and checking it out from the previous commit, but if I make any edit, it will do the same thing.

[CharonInferar]

If you cant fix it that way, just download a zip from git, extract the buff service file and copy it over your one. It will have the same hash as the master repo thus not seeing any change

[cdmpse]

Not sure what I'm doing wrong. That didn't seem to work.

[cdmpse]

That's why I removed the mods contained in the datatable and aren't zero from the script. I'm guessing movement was zero in the datatable so it could do checks to see if other movement modifiers were present. I thought calling the script will still be useful for that, the scripts will just have to be updated.

[Undercova]

The buff service checks if there is a buff script ... If not it will go for the datatable

All movement buffs have a value of 0 atm

Just skip this kind of fix/edit for now because the method or whatever will most likely change again :)

[cdmpse]

That part was commented out earlier. It goes for the datatable and never calls the script for add, but for remove it does. That's why your movement would just decrease when calling Charge or Scatter.

There are many zero values for movement in the buff.iff table, but there are lots of non-zeros too, is this file being manually updated? I thought it never was.

[Treeku]

It doesn't get updated.

You don't need to worry about buff scripts as it will be properly automated soon and all of the scripts deleted. SkillMod scripts should be worked on though.

[cdmpse]

Are all of the command scripts being deleted too?

[Undercova]

i think most of them ... yeah

[lewismorgan]

What did you change in quest service and quest task?

[cdmpse]

QuestTask:

• Added creatureType-relativeOffsetY(lines 50-55) and their getters and setters.

QuestService:

• Lines 244-250: added a check for CreateWaypoint in the task, if true it will create a waypoint from the datatable.
• Updated getQuestDatatable for the changes in QuestTask.
• Added a check (line 494) if file exists. Although I'm thinking now this probably isn't wanted.

[lewismorgan]

The file check isn't needed as getMethod will check if the file exists, otherwise it returns false. Some reason it's showing that you changed all the lines for the service files so I'm not able to tell what exactly was changed. Make sure you setup git to ignore line endings and space/tabs or w/e so if you change tabs to spaces in eclipse and update the file, git won't notice it.

[cdmpse]

Should be able to see now.

[lewismorgan]

Nice, thank you. Also, for the createWaypoint check, you'll need to change the handling for the go_to_location task type and the retrieve_item task type, otherwise 2 waypoints will be created right now because both of those have the createwaypoint boolean set at true I believe.

[cdmpse]

Removed all the non-quest stuff.

[lewismorgan]

Looks much better now, except you got methods being called duplicate in your signal scripts. Fix that then this is merged. Nice work :)

[cdmpse]

The completeActiveTasks in tat_eisley_tdc_eX? That's how the quest likes it. It seems like you skip two tasks per task for that quest.

[lewismorgan]

Ahh, I see. I'll see what's going on in the task handler.

[cdmpse]

About the two completeActiveTask calls in the scripts...

Now it works like:

1. Talk to NPC
2. Quest Updates immediately with next waypoint (2 tasks ahead from where you started.)

I'm thinking it should be (from memory):

1. Talk to NPC.
2. ActiveTask completes.
3. Pause a second.
4. ActiveTask completes and mission updates with new waypoint). Guessing those tasks that "pause" a second are the ""wait_for_signal" ones.

[cdmpse]

About the Chuba spawning... I was thinking that needs to be moved from where it is now, or will be updated in how it's done. What's there is just something to have in place for now.