search

ProjectSWGCore / NGECore2

The ProjectSWG Open Source Core
projectswg.com
GNU Lesser General Public License v3.0
23 stars 70 forks source link

Fixed up Tipping #1258

Closed RobUnderscore closed 9 years ago

RobUnderscore commented 9 years ago

Appears to be working well cross planet.

Working: /tip name 1000 /tip 1000 (with target) /tip name 1000 bank /tip 1000 bank (with target)

Not 100% sure how tipping worked in NGE, but currently 'target' is passed into the function as the current mouseover target. /tip 1000 if you only have somebody targeted (but not moused over) fails to tip.

Undercova commented 9 years ago

about to test it now :)

thanks so far

Undercova commented 9 years ago

trade

just had the problem of getting negative cash. and then you cant trade anymore (blocking) even when you are receiver

Undercova commented 9 years ago

every toon starts with 100 cash and 1000 in bank

after i tipped some money between 2 characters with cash and bank i managed to increase the money somehow. im at 2.300 money total so far

lewismorgan commented 9 years ago

you would be better off deleting the script and just re-doing it tbh. It was my first command I ever made, and global variables shouldn't be used in a script.

Also, use the system message's in the stf's, using the OutOfBand format like it was in live. This was made before we had proper use of stf's in, so I just set it to regular text. It would be really cool if you can find a way to not need global variables for the script as well, the reason is mainly for thread safety. I'm not sure how it would affect another player being tipped at around the same time.

RobUnderscore commented 9 years ago

Rewriting it entirely. Will submit a new request.