ProjectSWGCore / NGECore2

The ProjectSWG Open Source Core
projectswg.com
GNU Lesser General Public License v3.0
23 stars 70 forks source link

Fixed: Tips working (minus line of sight issues) #1260

Closed RobUnderscore closed 9 years ago

RobUnderscore commented 9 years ago

Fully refactored. Works in every case (that I tested for!) except when the target is in range but out of line of sight, which is beyond the scope of this script.

wallaceg09 commented 9 years ago

Did tips work across planets in the actual game? I distinctly remember having to run back to the cantina every time I forgot to tip an entertainer, or when I didn't have enough cash on hand for a decent tip...

Undercova commented 9 years ago

Bank tips did that

At range of 30m and more you auto bank tipped the money

RobUnderscore commented 9 years ago

The script as it was (before I rewrote it) had a range of 100m, at which point it just said 'out of range'. If the range was 30m, and beyond that a /tip name X or targeted /tip X defaulted to bank tip, I can rewrite it to do that.

Undercova commented 9 years ago

30m was a guess of me. 100m is even too much imo. Should be max 50 or so

RobUnderscore commented 9 years ago

Did it auto-fallover to bank tips beyond max range? I don't remember it doing that, but I played much more in Pre-CU and CU than I did in NGE.

Undercova commented 9 years ago

Afaik yes

It gave you the 5% fee sui window...