Closed singhayushh closed 3 years ago
Since the two issues (#2 and #7) are closely related, I have worked on them simultaneously. All changes have been made and I'll be creating a Pull Request very soon.
Kudos to you @singhayushh for this PR , the code is already looking much more organized🙌
Kudos to you @singhayushh for this PR , the code is already looking much more organized
Thank you! Happy to have helped ✌🏼
I am willing to take up this issue.
I have another suggestion regarding the code modularity. Currently the controller functions for each of the routes are written right inside the route definition. Example:
A good convention to follow is to create a controllers/ directory and have all these controller functions (let's call the above handler function as topSearchHandler) in there so that the api end point just has to call the function:
Originally posted by @singhayushh in https://github.com/ProjectSakura/Mirai/issues/2#issuecomment-794932074