ProjectSakura / ProjectSakura.github.io

Our official website, download center and blog.
https://projectsakura.me
MIT License
30 stars 44 forks source link

Removing redundency from blogs #291

Closed ritik307 closed 3 years ago

ritik307 commented 3 years ago

Describe the problem that you'd like solved

Proposal & Constraints

ritik307 commented 3 years ago

@LordShenron @ArunTeltia I would like to work on this issue so plz assign it to me.

LordShenron commented 3 years ago

@ritik307 This sound very fascinating but it would take a huge amount of work and will be hard to review too.. plus there could be issues with adsense.

ritik307 commented 3 years ago

@LordShenron Agreed! Let me try for the blog.html page since it doesn't have any ads. and it will be easier for you to review the PR as I will make multiple PRs for this issue.

LordShenron commented 3 years ago

@LordShenron Agreed! Let me try for the blog.html page since it doesn't have any ads. and it will be easier for you to review the PR as I will make multiple PRs for this issue.

there are ads in blog.html too but I kinda like this idea.. Correct me if I am wrong. You want only blog topics to be moved to a json file and clean up blog.html right? If we both are on the same page then you can go ahead with this issue.

ritik307 commented 3 years ago

@LordShenron Yup that's probably what I was talking about. As far as I know, the ads section won't be affected by it.

LordShenron commented 3 years ago

@LordShenron Yup that's probably what I was talking about. As far as I know, the ads section won't be affected by it.

You can do it "only" on blog.html. Go ahead with this issue, I am assigning it to you.

ritik307 commented 3 years ago

@LordShenron sure!

LordShenron commented 3 years ago

@ritik307 there are some routing issues with react. Think you can really do it?

ritik307 commented 3 years ago

@LordShenron what kind of routing issues you are talking about?

LordShenron commented 3 years ago

@ritik307 Content security restrictions that we are plagued with on our wiki and download page. You can only route traffic to the index and trying to send traffic to a specific page will end up with 404.

ritik307 commented 3 years ago

@LordShenron I am not getting it are you talking about the Link and anchor tag issue? like Link can only perform routing within the application and to route to different link outside the scope of the website we have to use the a tag. Is this the issue you are referring to?

LordShenron commented 3 years ago

@LordShenron I am not getting it are you talking about the Link and anchor tag issue? like Link can only perform routing within the application and to route to different link outside the scope of the website we have to use the a tag. Is this the issue you are referring to?

try visiting https://projectsakura.xyz/download/X00T and see console logs

ritik307 commented 3 years ago

image is this the issue you are referring to?

LordShenron commented 3 years ago

image is this the issue you are referring to?

looks like it;s getting cleaned up coz of our custom 404 page. try visiting this page, you can see the issue -> https://projectsakura.xyz/wiki/install-sakura

ritik307 commented 3 years ago

image Is this the issue?

LordShenron commented 3 years ago

image Is this the issue?

yup

ritik307 commented 3 years ago

image Is this the issue?

yup

I am familiar with this issue😁 , It can be fixed using Hash Router. I will fix this in wiki and downloads after implementing it on the blogs .

LordShenron commented 3 years ago

image Is this the issue?

yup

I am familiar with this issue, It can be fixed using Hash Router. I will fix this in wiki and downloads after implementing it on the blogs .

wiki is written in react but download is written in vue.. If you can fix it I will give you 1000billion points out of 100.

ritik307 commented 3 years ago

@LordShenron I will surely be able to fix it on the wiki but for download I have to do some research and will try my best to fix it.

LordShenron commented 3 years ago

@LordShenron I will surely be able to fix it on the wiki but for download I have to do some research and will try my best to fix it.

Go ahead and i will hire you instead of @ArunTeltia xD.. save your place @ArunTeltia bruu

ritik307 commented 3 years ago

πŸ˜‚πŸ˜‚πŸ˜‚πŸ˜‚

ArunTeltia commented 3 years ago

bruh F

ArunTeltia commented 3 years ago

I think we can close this, closing it for now