Show total validations on mission complete screen

[misaugstad]

Related to #1776

We are already keeping track of this on the front-end from issue #1776, so it would be easy to add it to the mission complete modal.

[misaugstad]

@shokiami please make a mock of what you're proposing to make the modal look like first before starting implementation. That way we can iterate on the design before you start diving into the code.

[shokiami]

@misaugstad Here are two mock ideas that utilize different message types (straight forward vs celebratory) and two different text placements. Please let me know what you feel is more user-friendly. Also, do you think it would be fun to change up the font/color of the text? mock1.pdf mock2.pdf

[jonfroehlich]

@shokiami for convenience and skimmability, please don't embed your mocks in PDFs (unless they are substantial in length). Instead, just screenshot them here.

I probably prefer Design 1. But we should only use one 'exclamation mark' (probably after Great Job!). So, the sentence would be: "You just validated 10 Missing Curb Ramp labels. Great Job!"

Design 1:

Design 2:

[shokiami]

@jonfroehlich Sounds good! I have attached two new designs that I wanted to quickly run by you. Design 1 is based on your previous suggestion, while Design 2 maintains the original order of the "Great Job! You just validated..." message and displays the "Total Validations" at the bottom as well as without the extra hyphens. I am happy to follow through with any combination of these formats. Please let me know what you prefer.

Also, I didn't realize pdfs do not display in comments, so thanks for the feedback!

Design 1:

Design 2:

[jonfroehlich]

Can you try a version with Total Validations in the table itself?

On Sat, Jun 27, 2020 at 12:56 PM Shosuke Kiami notifications@github.com wrote:

@jonfroehlich https://github.com/jonfroehlich Sounds good! I have attached two new designs that I wanted to quickly run by you. Design 1 is based on your previous suggestion, while Design 2 maintains the original order of the "Great Job! You just validated..." message and displays the "Total Validations" at the bottom as well as without the extra hyphens. I am happy to follow through with any combination of these formats. Please let me know what you prefer.

Also, I didn't realize pdfs do not display in comments, so thanks for the feedback!

Design 1: [image: design1] https://user-images.githubusercontent.com/43970567/85930954-46661100-b875-11ea-84f4-0fa2dee0ba1a.png

Design 2: [image: design2] https://user-images.githubusercontent.com/43970567/85930956-49610180-b875-11ea-935f-eba0969f5e34.png

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/ProjectSidewalk/SidewalkWebpage/issues/2130#issuecomment-650613028, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAML55MTKD56L73JUE6N4O3RYZFHBANCNFSM4NYWEAMA .

-- Jon Froehlich Associate Professor Paul G. Allen School of Computer Science & Engineering University of Washington http://makeabilitylab.io @jonfroehlich https://twitter.com/jonfroehlich - Twitter Help make sidewalks more accessible: http://projectsidewalk.io

[shokiami]

@jonfroehlich Sure thing!

[misaugstad]

Hmm I'm not sure I like it in the table as much as the other options. Do you have thoughts @jonfroehlich ?

[jonfroehlich]

I like the last one the best. Let's thicken that last line (like 2pt or 3pt line width) to distinguish it.

[shokiami]

@jonfroehlich Sounds good!

@misaugstad What do you think?

[jonfroehlich]

Can you darken a bit too?

Sent from my iPhone

On Jun 29, 2020, at 1:34 PM, Shosuke Kiami notifications@github.com wrote:

 @jonfroehlich Sounds good!

@misaugstad What do you think?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or unsubscribe.

[shokiami]

@jonfroehlich How does that look?

[jonfroehlich]

Good to me. Maybe switch to Overall Validations so it’s clear that it’s a count across label types and not just for the label type shown? But then I guess there is a question of whether you’re showing validation counts across users or just that user

Sent from my iPhone

On Jun 29, 2020, at 2:53 PM, Shosuke Kiami notifications@github.com wrote:

 @jonfroehlich How does that look?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or unsubscribe.

[shokiami]

@jonfroehlich "Overall Validations" makes sense to me. However, I hear your concern. How do you feel about "Your Total/Overall Validations"? Or is that too many words?

[jonfroehlich]

Let's try: "Your Total" or "Your Overall Total." I think the more concise one is better.

On Mon, Jun 29, 2020 at 5:37 PM Shosuke Kiami notifications@github.com wrote:

@jonfroehlich https://github.com/jonfroehlich "Overall Validations" makes sense to me. However, I hear your concern. How do you feel about "Your Total/Overall Validations"? Or is that too many words?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/ProjectSidewalk/SidewalkWebpage/issues/2130#issuecomment-651444928, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAML55LKH5ZCEITEWSJFHVLRZEXV7ANCNFSM4NYWEAMA .

-- Jon Froehlich Associate Professor Paul G. Allen School of Computer Science & Engineering University of Washington http://makeabilitylab.io @jonfroehlich https://twitter.com/jonfroehlich - Twitter Help make sidewalks more accessible: http://projectsidewalk.io

[shokiami]

@jonfroehlich Hmmm... I wonder if it is intuitive to the user what the number is referring to. What do you think?

[jonfroehlich]

I like your overall total for now. I don't think it's worth spending more time on. Let's ship it and move on. :)

The screen needs more work than this anyway longterm.

On Tue, Jun 30, 2020 at 12:49 PM Shosuke Kiami notifications@github.com wrote:

@jonfroehlich https://github.com/jonfroehlich Hmmm... I wonder if it is intuitive to the user what the number is referring to. What do you think?

[image: design1] https://user-images.githubusercontent.com/43970567/86170439-fafb6f00-bacf-11ea-8798-9d44250be5e9.png

[image: design2] https://user-images.githubusercontent.com/43970567/86170448-fc2c9c00-bacf-11ea-94ee-f1fd83590442.png

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/ProjectSidewalk/SidewalkWebpage/issues/2130#issuecomment-652006721, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAML55MSFHI3G7PR53QNS2LRZI6SXANCNFSM4NYWEAMA .

-- Jon Froehlich Associate Professor Paul G. Allen School of Computer Science & Engineering University of Washington http://makeabilitylab.io @jonfroehlich https://twitter.com/jonfroehlich - Twitter Help make sidewalks more accessible: http://projectsidewalk.io

[shokiami]

@jonfroehlich Sounds good!

[misaugstad]

closing via #2163