search

ProjectSidewalk / SidewalkWebpage

Project Sidewalk web page
http://projectsidewalk.org
MIT License
84 stars 24 forks source link

Reinstate label localization using depth data #2902

Closed misaugstad closed 2 years ago

misaugstad commented 2 years ago
Brief description of problem/feature

After months of having no depth data from Google, we removed our support for it in #2632 because it added a lot to code complexity. But the depth data endpoint has actually been back up for the last few months... I'm thinking that we should add this code back in so that we can have more accurate label lat/lngs for as long as this endpoint remains up?

jonfroehlich commented 2 years ago

Amazing. Is there an elegant way to add it back in (e.g., a separate .js file and a conditional that only uses depth triangulation if it exists)

misaugstad commented 2 years ago

Yep! I think we can keep it pretty short and sweet like that.

misaugstad commented 2 years ago

I'm not really sure what's going on... I went to bring the depth data back, but when I tried using our usual URLs to get depth data, they are returning 404 errors for me. Like the URL below should work: https://maps.google.com/cbk?output=xml&cb_client=maps_sv&hl=en&dm=1&pm=1&ph=1&renderer=cubic,spherical&v=4&panoid=tOANCSOy2o9zE39RfURKeA

The reason I'm really confused is because this URL seems to be working on the pano scraper that is live and running right now. The XML with depth data is being downloaded successfully every night. But if I try to use the same URL the following day to get the same XML, it doesn't work!

I even tried running the pano scraper locally, and the downloads were failing through that as well! I have no idea why the downloads are working on the live pano scraper, but not the one that I spun up locally..? I might try running the scraper locally from my home wifi instead of Starbucks wifi at some point over the next week. But for now I'm just really confused! And can't move forward with this while I'm failing to download depth data 🤷

misaugstad commented 2 years ago

I may have started working on this literally the day that the depth data endpoint was taken down again... It is fully no longer available :) So I am closing this issue unless and until the endpoint becomes available again!