ProjectSidewalk / SidewalkWebpage

Project Sidewalk web page
http://projectsidewalk.org
MIT License
83 stars 24 forks source link

Updates Pedestrian Signal tags #3501

Closed misaugstad closed 7 months ago

misaugstad commented 7 months ago

3240 (partially resolved)

NOTE: after discussion, these have been changed, see this comment below for up-to-date info on what was added in this PR.

The following changes are made to the Pedestrian Signal tags:

So the full list of tags is now:

Before/After screenshots (if applicable)

Before Screenshot from 2024-02-26 11-45-49

After Screenshot from 2024-02-26 11-46-07 Screenshot from 2024-02-26 11-46-11 Screenshot from 2024-02-26 11-46-17

Things to check before submitting the PR
misaugstad commented 7 months ago

After further discussion in #3240, here's where we're at now...

The following changes are made to the Pedestrian Signal tags:

So the full list of tags is now:

Before/After screenshots (if applicable)

Before Screenshot from 2024-02-26 11-45-49

After Screenshot from 2024-02-27 15-28-11 Screenshot from 2024-02-27 15-28-12 Screenshot from 2024-02-27 15-28-14 Screenshot from 2024-02-27 15-28-17

jonfroehlich commented 7 months ago

Looks great!

Sent from phone

On Tue, Feb 27, 2024 at 5:34 PM Michael Saugstad @.***> wrote:

After further discussion in #3240 https://github.com/ProjectSidewalk/SidewalkWebpage/issues/3240, here's where we're at now...

The following changes are made to the Pedestrian Signal tags:

  • Added "one button"
  • Added "two buttons"
  • Removed "has button" (turned all of those into "one button" so we don't throw away all info)
  • Added "hard to reach buttons"
  • Hid "button waist height" (bc it is replaced by "hard to reach buttons")
  • Renamed "APS" to "tactile-audible buttons"
  • Unhid "tactile-audible button" (formerly "APS")
  • Added example images to all available tags for Ped Signal

So the full list of tags is now:

  • one button
  • two buttons
  • hard to reach buttons
  • tactile-audible buttons

Before/After screenshots (if applicable)

Before Screenshot.from.2024-02-26.11-45-49.png (view on web) https://github.com/ProjectSidewalk/SidewalkWebpage/assets/6518824/32d7eece-4553-4a6c-b44e-261abd184a15

After Screenshot.from.2024-02-27.15-28-11.png (view on web) https://github.com/ProjectSidewalk/SidewalkWebpage/assets/6518824/e49fb25b-da94-4d77-a6fa-cb186c441394 Screenshot.from.2024-02-27.15-28-12.png (view on web) https://github.com/ProjectSidewalk/SidewalkWebpage/assets/6518824/2a9034cd-38ee-4f67-83c3-a85519f018bc Screenshot.from.2024-02-27.15-28-14.png (view on web) https://github.com/ProjectSidewalk/SidewalkWebpage/assets/6518824/08757825-116a-4da2-a77a-57cbc2d163d6 Screenshot.from.2024-02-27.15-28-17.png (view on web) https://github.com/ProjectSidewalk/SidewalkWebpage/assets/6518824/890623f9-4d3f-4fb9-9f61-6f6ecdbea9e0

— Reply to this email directly, view it on GitHub https://github.com/ProjectSidewalk/SidewalkWebpage/pull/3501#issuecomment-1967911520, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAML55NLHCHO2UFXAA7JTV3YVZURJAVCNFSM6AAAAABD22IOX6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSNRXHEYTCNJSGA . You are receiving this because you are subscribed to this thread.Message ID: @.***>