search

ProjectSidewalk / SidewalkWebpage

Project Sidewalk web page
http://projectsidewalk.org
MIT License
80 stars 23 forks source link

Some crops still have GSV street name overlays? #3503

Closed jonfroehlich closed 4 months ago

jonfroehlich commented 4 months ago

In rapidly reviewing a subset of our crops, I observed that some still have the streetview text overlay:

image

This is crop_temp_pittsburgh-pa_12692bf9-35f2-4a9a-8051-c31df62388a7_392_NoCurbRamp.jpg.png

jonfroehlich commented 4 months ago

Another example: image

crop_temp_pittsburgh-pa_12692bf9-35f2-4a9a-8051-c31df62388a7_338_Crosswalk.jpg.png

misaugstad commented 4 months ago

Looks like this was at least started, but we never actually merged this code in... https://github.com/ProjectSidewalk/SidewalkWebpage/compare/develop...save-crops

@hoominchu were we at a place where this was ready to go? Did I say I was going to test it or something and then dropped the ball?

hoominchu commented 4 months ago

yes, the code to fix is ready in branch: https://github.com/ProjectSidewalk/SidewalkWebpage/tree/save-crops

and right, it needs to be tested and released.

jonfroehlich commented 4 months ago

Glad I decided to actually look at how well the crops were working? :)