ProjectSidewalk / SidewalkWebpage

Project Sidewalk web page
http://projectsidewalk.org
MIT License
80 stars 23 forks source link

Remove road labels from saved crops #3505

Closed misaugstad closed 4 months ago

misaugstad commented 4 months ago

Resolves #3503

Written by @hoominchu

Hides the street names from the cropped image that we generate when a user places a label. We're doing this by hiding the road labels when a user chooses a label type and switches to "labeling mode"; after they place a label, we added a 20 ms delay before switching back to "walk mode", which then adds the road labels back.

In internal testing, 20 ms was enough time to save the images. And we don't expect the 20 ms delay to cause a problem for users bc it's a delay to move to a new pano; we expect users to be adding severity/tags to their labels after adding the label anyway, and this isn't inhibited at all.

Before/After screenshots (if applicable)

Before crop_temp_pittsburgh-pa_e7e6dc2f-a7a5-4b10-85d5-3191cd98b64f_16_SurfaceProblem jpg

After crop_temp_pittsburgh-pa_e7e6dc2f-a7a5-4b10-85d5-3191cd98b64f_15_SurfaceProblem jpg