ProjectSidewalk / SidewalkWebpage

Project Sidewalk web page
http://projectsidewalk.org
MIT License
83 stars 24 forks source link

Removed redudant call and dom modal clean up #3542

Closed JeremyFreiburger closed 4 months ago

JeremyFreiburger commented 5 months ago

Resolves #3512

The problem was opening a modal on the label map reinitialized the panorama every time creating too many web gl elements. I also have to remove the code to remove the modal because I think it is interfering with bootstraps garbage collection/reusing modals.

Before/After screenshots (if applicable)
Testing instructions
  1. I tested pretty thoroughly, for each label type, validation type, and other data imported to make sure that it is the panorama that is creating too many webgl elements. When I only remove the reset call the problem still occurs.
Things to check before submitting the PR
misaugstad commented 5 months ago

Awesome!! Does removing the call to resetModal() cause any issues? Is all the data getting updated to the new label without the resetModal call?

And since this code is used in lots of places, I'm going to list all the places I can think of here. Can you check each place to see if it's an issue there on develop, and then make sure it's fixed in any places where it's an issue?

  1. LabelMap
  2. Admin page, "Map" tab
  3. Admin page, "Contributions" tab
  4. Admin user dashboard at /admin/user/\<username>
misaugstad commented 4 months ago

closing in favor of #3549