Added check for 404 bug, and removed labelmap breaking code

JeremyFreiburger commented 1 month ago

Resolves #3512

I removed the modal clean up code in the labelmap file and I added a check when resetting the panorama in the gsv label view file. When I removed the _resetModal call in the showLabel method the code works fine for all four of the locations(labelMap, admin dashboard, contributions, adminmap). However, I found a bug on the contributions tab which occurs when a gsv is deleted by google.

The steps to reproduce this bug(with screenshots below), is to go to the admin contributions tab and go to the very last page and click on a gsv that is deleted(NoCurbRamp severity 3 on the last page), then click on another gsv that is not deleted(any of the top curb ramps) and these should log a 404 error to the console. After I click on a few other gsv's that are not deleted the issue fixes itself. I solved this issue by calling _resetModal everytime a user clicks on a deleted gsv. If deleted labels are removed the contributions tab, this issue will also fix itself.

Before/After screenshots (if applicable)

Testing instructions

Things to check before submitting the PR

[ ] I've written a descriptive PR title.
[x] I've added/updated comments for large or confusing blocks of code.
[x] I've included before/after screenshots above.
[ ] I've asked for and included translations for any user facing text that was added or modified.
[ ] I've updated any logging. Clicks, keyboard presses, and other user interactions should be logged. If you're not sure how (or if you need to update the logging), ask Mikey. Then make sure the documentation on this wiki page is up to date for the logs you added/updated.
[ ] I've tested on mobile (only needed for validation page).

misaugstad commented 1 month ago

@JeremyFreiburger okay so this PR now supersedes #3542 and is still meant as a fix for #3512?

And can you confirm if/when you've tested in the four places mentioned here?

JeremyFreiburger commented 1 month ago

Yes, this pr fixes #3512, and i've tested it in the 4 places.

ProjectSidewalk / SidewalkWebpage