Add Validation Comments

cyrusnaficy commented 1 week ago

Resolves #3016

Added validation comments to the label map. If there are multiple comments, they will be seperated by a horizontal line. If there are no comments, it will display "None".

How response looks for labelID (ex.)

{
    "label_id": 49965,
    "gsv_panorama_id": "mQdJ0civrV0Em2LfNOdN5Q",
    "tutorial": false,
    "image_capture_date": "2018-09",
    "heading": 155.90847778320312,
    "pitch": -6.375,
    "zoom": 1,
    "canvas_x": 238,
    "canvas_y": 379,
    "street_edge_id": 17750,
    "region_id": 30,
    "timestamp": 1556944464421,
    "label_type_key": "SurfaceProblem",
    "label_type_value": "Surface Problem",
    "severity": 4,
    "temporary": false,
    "description": null,
    "user_validation": null,
    "num_agree": 1,
    "num_disagree": 2,
    "num_notsure": 1,
    "comments": [
        "doesn't look like a severity 4 crack",
        "Crack doesn't look severe enough to be an issue"
    ],
    "tags": []
}

Before/After screenshots (if applicable)

Before

After

Testing instructions

Go to the label map.
Open a label and enter a comment
Re-open it and validator commentz will appear.

Things to check before submitting the PR

[x] I've written a descriptive PR title.
[x] I've added/updated comments for large or confusing blocks of code.
[x] I've included before/after screenshots above.
[x] I've asked for and included translations for any user facing text that was added or modified.

cyrusnaficy commented 1 week ago

Okay this looks really good!! Don't be discouraged by the 10+ comments I added 😂 A lot of them are nit-picky about style or are slightly simpler ways to write things. Ultimately the code works, I just want us to get the code to a really good state!

I made some changes on the develop branch, and it looks like there are merge conflicts... Could you pull in the most recent changes from develop into your branch (if on your branch, running git pull origin develop and then fixing any issues with it and testing again)?

Sorry for the styling issues, will make sure I review the guide before requesting review for new PRs. I commited changes for all the above. Thanks for the comments!

misaugstad commented 1 week ago

I didn't check everything just now, but I left one comment, and I also noticed that you haven't pulled in changes from develop and resolved merge conflicts yet. From what else I saw though, it's looking real good!

cyrusnaficy commented 1 week ago

I didn't check everything just now, but I left one comment, and I also noticed that you haven't pulled in changes from develop and resolved merge conflicts yet. From what else I saw though, it's looking real good!

Thanks, just resolved merge conflicts.

misaugstad commented 6 days ago

@cyrusnaficy you'll need to check to make sure that everything is working correctly after resolving merge conflicts! Just because you resolved everything that git noticed, doesn't mean that everything works properly! And taking a look at your merge, it looks like you left in the "<<<<<<< HEAD" lines and such, which are giving compilation errors!

ProjectSidewalk / SidewalkWebpage