jonfroehlich
commented
3 months ago If label starts behind mini-map, just move minimal to bottom left rather than the default of bottom-right?
Sent from phone
On Fri, Jun 28, 2024 at 8:22 PM Michael Saugstad @.***> wrote:
Brief description of problem/feature
Since adding a minimap to all versions of Validate (PR #3576 https://github.com/ProjectSidewalk/SidewalkWebpage/pull/3576), we now have an issue where the label can be hidden behind the mini map immediately when we show it to them. This is because we try to pan the user to the view that the labeler had when they added it, expecting it to give better context than just centering the label. But that's not going to fly if the label is just completely hidden! Potential solution(s)
The easiest thing would be to have the label show up above the minimap no matter what... This looks funky. Screenshot.from.2024-06-28.19-16-59.png (view on web) https://github.com/ProjectSidewalk/SidewalkWebpage/assets/6518824/cff11bdc-aa69-4f7c-b84a-c2a6bf3c3b73
Next could be to mess with the opacity of the minimap if the label is underneath it. Better... Still kinda weird? Idk I think I need to look at it again with fresh eyes later. Could also just fully hide the minimap if the label is behind it. Screenshot.from.2024-06-28.19-18-18.png (view on web) https://github.com/ProjectSidewalk/SidewalkWebpage/assets/6518824/e5e1a49c-d915-4886-96e1-42a735d90d5b
Another option is to detect if the label is going to show up under the minimap, and auto-pan the GSV so that the label doesn't start behind the minimap. The only downside to this one (aside from code complexity) is that users can still pan so that the label ends up behind the minimap on their own. Though this method could be combined with another method so that the label remains visible if the user pans to make it under the minimap.
— Reply to this email directly, view it on GitHub https://github.com/ProjectSidewalk/SidewalkWebpage/issues/3582, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAML55ORESUIYVW3ZDTTQZ3ZJYK5DAVCNFSM6AAAAABKCZDBB6VHI2DSMVQWIX3LMV43ASLTON2WKOZSGM4DCNBRGI2DSOI . You are receiving this because you are subscribed to this thread.Message ID: @.***>
misaugstad
Brief description of problem/feature
Since adding a minimap to all versions of Validate (PR #3576), we now have an issue where the label can be hidden behind the mini map immediately when we show it to them. This is because we try to pan the user to the view that the labeler had when they added it, expecting it to give better context than just centering the label. But that's not going to fly if the label is just completely hidden!
Potential solution(s)
The easiest thing would be to have the label show up above the minimap no matter what... This looks funky.
Next could be to mess with the opacity of the minimap if the label is underneath it. Better... Still kinda weird? Idk I think I need to look at it again with fresh eyes later. Could also just fully hide the minimap if the label is behind it.
Another option is to detect if the label is going to show up under the minimap, and auto-pan the GSV so that the label doesn't start behind the minimap. The only downside to this one (aside from code complexity) is that users can still pan so that the label ends up behind the minimap on their own. Though this method could be combined with another method so that the label remains visible if the user pans to make it under the minimap.