ProjectSidewalk / SidewalkWebpage

Project Sidewalk web page
http://projectsidewalk.org
MIT License
84 stars 25 forks source link

Last short street segments in neighborhood not being assigned on Explore page #3647

Closed misaugstad closed 1 month ago

misaugstad commented 2 months ago
Brief description of problem/feature

There are a bunch of neighborhoods in Seattle that are 99% complete. Most of them have one to three very short streets that haven't been audited no them. If I try to audit the neighborhood, it doesn't assign me those short streets. I'm not sure if this is a problem with the back end or front end (or both).

I've been going through a few of these streets. Occasionally one will be impossible to complete because of missing imagery (which I've then marked them as "deleted" in the db). But for the most part I can audit them just fine by going directly to the street (https://sidewalk-sea.cs.washington.edu/explore/street/<street-id>).

Since I've been fixing these, you won't see as many 99% neighborhoods in Seattle, but there are still some remaining!

Expected behavior

If you go to Explore a region, we should always be serving streets that haven't yet been audited first.

Steps to reproduce

Find a neighborhood that's 99% complete. Choose to audit that neighborhood from the landing page choropleth. Run this in the browser console to check the street "priority". You want the priority to be 1, meaning it hasn't been audited yet.

svl.taskContainer.getCurrentTask().getStreetPriority()

If you've already audited in this neighborhood, you might just be on the street that you were previously assigned. So you may need to finish the street you're on or click the "Jump" button to go to a no place in the neighborhood and check the street priority again. If it's still less than 1, then you're not being assigned the correct street!

misaugstad commented 1 month ago

WELL @srihariKrishnaswamy spent some time investigating this and couldn't reproduce... So I tried to reproduce locally and also couldn't... Then I tried on prod where I was initially experiencing the bug and again was not having an issue! Maybe I was just confused because of cases where I had already started auditing a different street in the neighborhood? Either way, we've pretty thoroughly tested this and it doesn't seem to be a problem, so I'm going to close it now.