ProjectSidewalk / SidewalkWebpage

Project Sidewalk web page
http://projectsidewalk.org
MIT License
84 stars 25 forks source link

Changed quarterly Google Update for API to Weekly #3672

Open aslassi777 opened 1 month ago

aslassi777 commented 1 month ago

Resolves #3620

Looked into Google Maps API potential update issues. Specifically, used beta channel in localhost to ensure that the small google maps (to the right of the street view) works as intended and does not require any updates to the code. Tested by setting the channel to beta and doing a few explore missions on my computer in localhost. Did not see any changes. Updated the api key to weekly now per @misaugstad request (only thing that was changed).

Related links:

https://developers.google.com/maps/documentation/javascript/releases https://developers.google.com/maps/documentation/javascript/versions

Before/After screenshots (if applicable)

N/A

Testing instructions

N/A

Things to check before submitting the PR
misaugstad commented 1 month ago

@aslassi777 The reason for the ticket is that Google is making this new "Camera" control the default over the previous "Zoom" control, so I'd like for us to switch over to the new control even if using the old control isn't breaking anything on the beta channel!

And in the PR template, if you replace the " " with an "x" instead of just adding an "x", it will render as checked checkboxes like this!

aslassi777 commented 1 month ago

thanks @misaugstad for clarification, will do! @misaugstad just to make sure, this is for the mini map on the right side of the explore/missions page correct? I'm looking at the controls for that map and it seems that the zoomControl is set to false (this might end up having to get removed). Maybe this is why it wasn't broken when I switched over to beta channel. It also seems that we have defaultUI set to false, which prohibits the new camera controls from being used in the default settings (when on beta channel) per the google website. I'll add in the new camera controls and see what changes...

Also, I'm just going to put some links here for my own reference:

Controls: https://developers.google.com/maps/documentation/javascript/controls Default UI: https://developers.google.com/maps/documentation/javascript/controls#DefaultUI Camera Controls Interface: https://developers.google.com/maps/documentation/javascript/reference/control#CameraControlOptions

misaugstad commented 1 month ago

this is for the mini map on the right side of the explore/missions page correct

correct!

the zoomControl is set to false (this might end up having to get removed). Maybe this is why it wasn't broken when I switched over to beta channel. It also seems that we have defaultUI set to false, which prohibits the new camera controls from being used in the default settings (when on beta channel) per the google website. I'll add in the new camera controls and see what changes...

Yep, expected as much! I'm hoping that you can work through the documentation and the different types of control settings to figure out what exists now, what the recommended controls are in the future, and to set up the controls to work going forward using their suggested controls, hopefully as simply as possible!

aslassi777 commented 1 month ago

@misaugstad sounds good will do! I'm going to check out #3676 for a little bit