ProjectSidewalk / SidewalkWebpage

Project Sidewalk web page
http://projectsidewalk.org
MIT License
84 stars 25 forks source link

Adding Keyboard Shortcuts for New Validate Beta #3701

Closed nehaa2426 closed 3 weeks ago

nehaa2426 commented 1 month ago

Resolves #3675

Testing instructions
  1. Go onto the New Validate Beta and start validating
  2. At each of the sections (Yes, No, Unsure) click 1/2/3 to see that it appropriately chooses a severity or reason
  3. Make sure that if you are on No, for example, and click 2, the Yes page does not also update to 2 severity
  4. At the No/Unsure sections, click 4 to see that it enters the text box and esc to exit the box
Things to check before submitting the PR
nehaa2426 commented 4 weeks ago

[cid:e65e6898-2055-4fd8-b20c-522400d3119c] Hmm, it shows that it has updated on my end in github, I am not sure why it is not showing up on your end


From: Michael Saugstad @.> Sent: Wednesday, October 23, 2024 3:26 PM To: ProjectSidewalk/SidewalkWebpage @.> Cc: Neha Aitharaju @.>; Assign @.> Subject: Re: [ProjectSidewalk/SidewalkWebpage] Adding Keyboard Shortcuts for New Validate Beta (PR #3701)

@misaugstad commented on this pull request.


In public/javascripts/SVValidate/src/keyboard/Keyboard.jshttps://github.com/ProjectSidewalk/SidewalkWebpage/pull/3701#discussion_r1813812364:

@@ -82,10 +82,55 @@ function Keyboard(menuUI) { } }

This is still an issue

— Reply to this email directly, view it on GitHubhttps://github.com/ProjectSidewalk/SidewalkWebpage/pull/3701#discussion_r1813812364, or unsubscribehttps://github.com/notifications/unsubscribe-auth/A7VSWHDQHZX5HYD4GMM3JLTZ5APCXAVCNFSM6AAAAABQNEBMDCVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDGOJQG43TAMBXGE. You are receiving this because you were assigned.Message ID: @.***>

misaugstad commented 4 weeks ago

Hmm, it shows that it has updated on my end in github, I am not sure why it is not showing up on your end

The formatting got wonky, but from what I think you're referring to: you changed it in the one place where I added the comment, but there were numerous other places where the same mistake was made.

nehaa2426 commented 4 weeks ago

Gotcha, I made sure to check for it throughout my code and made changes. I also did review the whole code quality guide and made changes according to that!


From: Michael Saugstad @.> Sent: Wednesday, October 23, 2024 3:40 PM To: ProjectSidewalk/SidewalkWebpage @.> Cc: Neha Aitharaju @.>; Assign @.> Subject: Re: [ProjectSidewalk/SidewalkWebpage] Adding Keyboard Shortcuts for New Validate Beta (PR #3701)

Hmm, it shows that it has updated on my end in github, I am not sure why it is not showing up on your end

The formatting got wonky, but from what I think you're referring to: you changed it in the one place where I added the comment, but there were numerous other places where the same mistake was made.

— Reply to this email directly, view it on GitHubhttps://github.com/ProjectSidewalk/SidewalkWebpage/pull/3701#issuecomment-2433652576, or unsubscribehttps://github.com/notifications/unsubscribe-auth/A7VSWHEWDACXLQDSFTP3YGDZ5AQVVAVCNFSM6AAAAABQNEBMDCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDIMZTGY2TENJXGY. You are receiving this because you were assigned.Message ID: @.***>